Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Update frameKey in aboutDetails when clone about pages #5015

Merged
merged 1 commit into from
Oct 24, 2016

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Oct 20, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

fix #4984

Auditors: @bsclifton

Test Plan:

  1. generate error page (ex. connection lost)
  2. clone the error tab
  3. retry on the cloned tab of step2
  4. reload should happen on the cloned tab

fix brave#4984

Auditors: @bsclifton

Test Plan:
1. generate error page (ex. connection lost)
2. clone the error tab
3. retry on the cloned tab of step2
4. reload should happen on the cloned tab
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Retry the URL" on cloned error tab is retried on the original tab
5 participants